[coreboot-gerrit] New patch to review for coreboot: 6735199 northbridge/amd/amdmct: Incorrect usage of logical over bitwise and

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5820

-gerrit

commit 6735199e9d6d65bd55564cf4228ceda0cff4456f
Author: Edward O'Callaghan 
Date:   Fri May 23 07:11:14 2014 +1000

northbridge/amd/amdmct: Incorrect usage of logical over bitwise and

Small mix up of logical/bitwise logical and operation. Spotted by Clang.

Change-Id: I2c2256b9b2f2b6ca627914118c745f579555acc9
    Signed-off-by: Edward O'Callaghan 
---
 src/northbridge/amd/amdmct/wrappers/mcti_d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
index 8c45332..0119ae6 100644
--- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c
+++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c
@@ -459,7 +459,7 @@ static void vErratum414(struct DCTStatStruc *pDCTstat)
         int powerDown =  dRAMConfigHi && (1 << PowerDownEn ) ;
         int ddr3 = dRAMConfigHi && (1 << Ddr3Mode ) ;
         int dRAMMRS = Get_NB32(pDCTstat->dev_dct,0x84 + (0x100 * dct));
-        int pchgPDModeSel = dRAMMRS && (1 << PchgPDModeSel ) ;
+        int pchgPDModeSel = dRAMMRS & (1 << PchgPDModeSel);
    if (powerDown && ddr3 && pchgPDModeSel )
    {
      Set_NB32(pDCTstat->dev_dct,0x84 + (0x100 * dct), dRAMMRS & ~(1 << PchgPDModeSel) );