Attention is currently required from: Lee Leahy, Paul Menzel, Angel Pons, Huang Jin, Patrick Rudolph.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61333 )
Change subject: drivers/intel/fsp1_1/raminit.c: Use PRIxPTR macro
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61333/comment/132889ce_e945358d
PS3, Line 8:
What warning/error is shown by the compiler?
'smm_base' is a uintptr_t, it needs the PRIxPTR format.
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/61333/comment/111290a8_11abdd95
PS3, Line 139: %" PRIxPTR "
Maybe %zx ?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06cb882d55299568844cfc9bd04e288d453cd61c
Gerrit-Change-Number: 61333
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Huang Jin
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Huang Jin
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 20 Nov 2022 06:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment