15 Jul
2019
15 Jul
'19
2:33 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31478/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31478/14//COMMIT_MSG@8 PS14, Line 8: Please give more details for a change-set with such a big diffstat.
Also, display driver is ambiguous. I guess graphics/GFX driver is better, because display driver could also be the “panel” driver, couldn’t it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4aecc58d081f14f5d136b9ff8e813e6f40f78eb
Gerrit-Change-Number: 31478
Gerrit-PatchSet: 14
Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-Reviewer: Chun-ta Lin itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Yongqiang Niu yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Jul 2019 12:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment