Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35678 )
Change subject: intel/i945,i82801gx: Refactor early PCI bridge reset
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35678/1/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/35678/1/src/northbridge/intel/i945/...
PS1, Line 876: mdelay(200);
If there is a PCI(e/-X) specification requirement for an assertion to have some duration. […]
I only found 1ms Trst for RST# assertion in the specs.
I am pretty sure this 200ms was discussed once before, maybe in relation to some exotic add-on PCI hardware? It might be just a delay in general, RST# asserted or not, that was required.
commit bc8613ec
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd5cd2afc8e41cc50abdda0fb7d063073c3acdc1
Gerrit-Change-Number: 35678
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Comment-Date: Mon, 30 Sep 2019 09:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Petr Cvek
petrcvekcz@gmail.com
Gerrit-MessageType: comment