Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46461 )
Change subject: soc/intel/skl: replace conditional on dt option reading CPUID for CPPC
......................................................................
Patch Set 11: Code-Review+1
Well, I'm not sure if it's really worth adding a function for two checks, where one will vanish soon (when SKL uses common acpi code). I could add it, though
How is this done in common ACPI code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9bf09385627fb6a1d8e566a80370f7ddd8605e
Gerrit-Change-Number: 46461
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Oct 2020 00:29:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment