Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: add initial board files ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig@27 PS7, Line 27: config BOARD_ROMSIZE_KB_6144 : bool I would mention this in the commit message.
https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/Makefil... File src/mainboard/samsung/350v5c/Makefile.inc:
https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/Makefil... PS7, Line 2: ramstage-y += um?
https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb:
https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/devicet... PS7, Line 2: , 0x80000410, 0x00000005 These can be dropped.