Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61455 )
Change subject: soc/intel/cannonlake: Drop unnecessary guard for HECI1 disable FSP UPD
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/61455/comment/012c2fcf_4e6005b7
PS5, Line 590: params->Heci1Disabled = CONFIG(DISABLE_HECI1_AT_PRE_BOOT);
I thought the point was letting coreboot do the disable, so this would be `0` ?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8908c080ca9991e7a71e795ccb8fc76d99514f8
Gerrit-Change-Number: 61455
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Feb 2022 10:00:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment