Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37486 )
Change subject: rules.h: Add ENV_EARLY_RAM ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h@259 PS1, Line 259: #define ENV_EARLY_RAM (ENV_ROMSTAGE_OR_BEFORE && CONFIG(RESET_VECTOR_IN_RAM))
I read ENV_CAR (and I wrote ENV_EARLY_RAM) to indicate any time when that mode is active, not that t […]
I left a comment on CB:37487. Anyways, someone else will decide about the +2 for this one, probably Aaron or Julius.
I think the current choice of name is very descriptive for choosing between two linker scripts, one for XIP+CAR another for loading reset vector and program into RAM.
https://review.coreboot.org/c/coreboot/+/37486/1/src/include/rules.h@261 PS1, Line 261: #define ENV_STAGE_HAS_DATA_SECTION (!ENV_CACHE_AS_RAM && !ENV_EARLY_RAM)
The elf-to-image creation/compression feature of cbfstool only takes the elf file's PROGBITS. […]
Hmm.. but .data would be PROGBITS? For XIP romstage, runtime needs to be modified to load .data in to CAR region, but with non-XIP you would get this for free, copied to RAM with the rest of program?
The benefit: less deviation from standard C for developer? The only place right now I think would benefit from this would be DECLARE_SPINLOCK() .