Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common: Add function to check if PCI device is a LPSS controller
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34137/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/3/src/soc/intel/common/block/...
PS3, Line 44: __weak
If a SoC is selecting LPSS common block, I would expect it to always provide the definition of soc_l […]
LPSS controller check was currently needed for irq table implementation. Since plan was to support it to CNL onwards, the weak implementation is for older platforms.
https://review.coreboot.org/c/coreboot/+/34137/3/src/soc/intel/common/block/...
PS3, Line 43: /* SoC override function */
: __weak const int *soc_lpss_controllers(size_t *size)
: {
: return NULL;
: }
:
If you set *size to 0, then a NULL check is not needed while looping over the returned array.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5bb268fc581280bb1b87b6b175a0299a24a44a
Gerrit-Change-Number: 34137
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 15 Jul 2019 14:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment