[coreboot-gerrit] Change in coreboot[master]: mainboard/amd: Add padmelon board code

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )

Change subject: mainboard/amd: Add padmelon board code
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... 
File src/mainboard/amd/padmelon/irq_tables.c:

https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... 
PS7, Line 41: unsigned long write_pirq_routing_table(unsigned long addr)
> All family 15h platforms use the very same file... […]

PIRQ table can be completely broken and OS boots just fine. If you find mistakes here, probably all the other fam15 have same errors. My quick solution; push commit without PIRQ and MP, there are Kconfigs for both.

There may be shortcuts taken here. In ideal world, PIRQ tables will be different depending of which SERIRQ the on-board superio needs to drive.