Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: arch/x86: Helper functions to get deterministic cache parameters ......................................................................
Patch Set 2:
(3 comments)
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/55965/comment/c85dbc38_9fca7fbf PS1, Line 329: get_cache_info
Yeah that sounds good, take the leaf and the ecx argument
Ack
https://review.coreboot.org/c/coreboot/+/55965/comment/027ecd46_97c9a41c PS1, Line 331: 0x03
For this case, it would still be useful, […]
Ack
https://review.coreboot.org/c/coreboot/+/55965/comment/24a3c7ba_0ebd323d PS1, Line 332: : const size_t assoc = CPUID_CACHE_WAYS_OF_ASSOC(res) + 1; : const size_t partitions = CPUID_CACHE_PHYS_LINE(res) + 1; : const size_t cache_line_size = CPUID_CACHE_COHER_LINE(res) + 1; : const size_t number_of_sets = CPUID_CACHE_NO_OF_SETS(res) + 1; : const size_t cache_size = assoc * partitions * cache_line_size * number_of_sets; : printk(BIOS_INFO, "Cache Information : "); : printk(BIOS_INFO, "assoc=%zd par=%zd line_size=%zd sets=%zd\n", : assoc, partitions, cache_line_size, number_of_sets); : printk(BIOS_INFO, "@@ cache_size 0x%lx bytes\n", cache_size);
thats good idea may be
Ack