Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@26 PS3, Line 26: - The Fn key is on by default
From the cbmem log I can see the EC firmware ID and version are read correctly, but I don't know wha […]
I misunderstood the meaning of sticky_fn ("Fn Sticky" in the OEM setting). The coreboot h8 code still works. What we need is to add a "F1-F12 as Primary" option.
There's no known way to disable the touchpad, and bt/wwan is disabled by disabling the USB port instead of using EC, so I remove these CMOS options.
https://review.coreboot.org/c/coreboot/+/34359/5/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t440p_all_flash_chips.jpg:
PS5:
NM-A131... Schematics for this board say it has a SMSC MSC1633 EC. […]
There's no H8S starting from xx30 series, but the EC interface still works.
https://review.coreboot.org/c/coreboot/+/34359/5/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/romstage.c:
https://review.coreboot.org/c/coreboot/+/34359/5/src/mainboard/lenovo/t440p/... PS5, Line 66: dimm_channel0_disabled
google/slippy/variants/wolf has the following values for this: […]
Oh, I forgot to disable one dimm.