Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50790 )
Change subject: device/azalia_device: Fix STATESTS register and add defines
......................................................................
Patch Set 2:
(1 comment)
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/50790/comment/dde2856b_bc0c08f0
PS2, Line 16: HDA_MAX_CODECS
Is this limit chipset-specific? If so, I'd turn it into a Kconfig option and derive the HDA_CODEC_MASK macro from that Kconfig option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7859ed33e58d907a91c4ac8675892e37998cf41
Gerrit-Change-Number: 50790
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 10:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment