[coreboot-gerrit] Change in coreboot[master]: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 )

Change subject: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC
......................................................................


Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37792/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37792/4//COMMIT_MSG@13 
PS4, Line 13: load the logo
> The soc_load_logo actually passes the pointer and length to the FSP. […]
> Done

https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo... 
File src/drivers/intel/fsp2_0/logo.c:

https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo... 
PS4, Line 29: 			if (logo_size)
            : 				*logo_ptr = (UINT32)logo_buffer;
> No. The logo_entry points to the allocated cbmem structure. […]
> Ok, this is what I said for a invalid logo instance we can remove the cbmem entry here itself and set the logo_entry to NULL and not reserve it further.
> remove routine would find the logo_entry null and would not invoke the cbfs remove. thoughts?