Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 )
Change subject: google/kukui: Move some initialization from bootblock to verstage.
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
Thanks! LGTM after you make Jenkins happy.
https://review.coreboot.org/#/c/30331/11/src/mainboard/google/kukui/early_in...
File src/mainboard/google/kukui/early_init.c:
https://review.coreboot.org/#/c/30331/11/src/mainboard/google/kukui/early_in...
PS11, Line 28: mt8183_early_init();
Need to link this into romstage as well now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9968d88c54283ef334d1ab975086d4adb3363bd6
Gerrit-Change-Number: 30331
Gerrit-PatchSet: 11
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 25 Jan 2019 00:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment