Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33395 )
Change subject: mb/google/octopus: Override VBT selection for Garg ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/garg/Makefile.inc:
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 2: ramstage-y += mainboard.c Move this line after ramstage-y += gpio.c
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/garg/mainboard.c:
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 1: /* Rename this file to variant.c
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 4: 2018 2019
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant... PS3, Line 30: google_chromeec_cbi_get_sku_id Can you please use get_board_sku from src/mainboard/google/octopus/mainboard.c. That way it can return the cached sku id information without checking with EC.