Attention is currently required from: Martin Roth, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44772 )
Change subject: mb/prodrive/hermes/hda_verb: Update verb table for latest board revision ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/bb9ddb1c_c352654e PS7, Line 34: AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* PORT B - rear mic in */ Place this one right after 0x17?
File src/mainboard/prodrive/hermes/variants/r02/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/44772/comment/9bee6142_e24c883c PS7, Line 12: AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* port A - audio hdr input */ I wonder if we could program these settings statically, and override them for r03+
https://review.coreboot.org/c/coreboot/+/44772/comment/20482fa8_827e0094 PS7, Line 18: return; Should we move this check out of the revision-specific boards? We could then rename these functions to `mainboard_r0x_configure_alc888` or similar