Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30432 )
Change subject: drivers/smmstore: Fix some issues
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/30432/6/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/30432/6/src/drivers/smmstore/store.c@187
PS6, Line 187: if (scan_end(&end) == CB_ERR)
We're doing lookup_store() inside of scan_end(). […]
We don't seem to have functions to return cbfsfiles as writable region?
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c
File src/drivers/smmstore/store.c:
https://review.coreboot.org/#/c/30432/8/src/drivers/smmstore/store.c@94
PS8, Line 94: -1
CB_ERR (here, and rest of file?)
The interface is defined above and the function calling it also uses plain numbers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I629be25d2a9b65796ae8f7a700b6bdab57b91b22
Gerrit-Change-Number: 30432
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 09 Jun 2019 09:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment