Attention is currently required from: Nico Huber, Paul Menzel, Tim Wawrzynczak, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Add new Kconfig VGA_ROM_RUN_DEFAULT for mainboard to select ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49016/comment/baa37233_f2849022 PS5, Line 7: non-FSP solution
It doesn't really matter if FSP is used or not (coreboot is not […]
Ack
https://review.coreboot.org/c/coreboot/+/49016/comment/199b6f38_c3546eab PS5, Line 12: 1. For onboard graphics initialization, GFX PEIM module inside : FSP binary is taking care of graphics initialization based on : HAVE_FSP_GOP Kconfig option and input VBT file. Hence no need : to load/execute legacy VGA OpROM in order to initialize onboard GFX. : : 2. In case of non-FSP solution, platform needs to select VGA_ROM_RUN : Kconfig to perform graphics initialization for PCI-E based discrete : card through VGA OpRom (SoC or Mainboard user can't select VGA_ROM_RUN : directly because it's part of choice option).
This is only background information and mostly wrong (wrt. coreboot […]
Ack
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/comment/f4390810_81c8f5ce PS4, Line 53: discrete graphics card
It doesn't seem like we need the IGPU/DGPU distinction right now. Loading […]
Ack