Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52894 )
Change subject: include/console: Fix comments for FSP Notify End of Firmware postcodes ......................................................................
Patch Set 1:
(3 comments)
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52894/comment/da6175c5_07146876 PS1, Line 209: phase Probably say "(end of firmware)" after phase? Same for after call?
https://review.coreboot.org/c/coreboot/+/52894/comment/42935a25_6518ea45 PS1, Line 256: before This seems to have the same problem.
https://review.coreboot.org/c/coreboot/+/52894/comment/b8a837cb_11b4fe54 PS1, Line 260: POST_FSP_NOTIFY_BEFORE_FINALIZE Just noticed that we are incorrectly using this even after finalize notification is done: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
Same for enumeration phase.