28 Sep
2020
28 Sep
'20
12:27 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39766 )
Change subject: drivers/i2c/nct7802y: Configure remote diodes and local sensor ......................................................................
Patch Set 31:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n... File src/drivers/i2c/nct7802y/nct7802y_fan.c:
https://review.coreboot.org/c/coreboot/+/39766/31/src/drivers/i2c/nct7802y/n... PS31, Line 81: value = 0
Hmmm, the variable is used for multiple things, would be odd to not have […]
Right, sounds good.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39766
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28cc4e5cae76cf0bcdad26a50ee6cd43a201d31e
Gerrit-Change-Number: 39766
Gerrit-PatchSet: 31
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Sep 2020 10:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment