[coreboot-gerrit] [M] Change in coreboot[main]: device/pciexp_device.c: Fix setting Max Payload Size

[Michał Żygowski (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Krystian Hebel, Kyösti Mälkki, Nico Huber, Patrick Rudolph.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77338?usp=email )

Change subject: device/pciexp_device.c: Fix setting Max Payload Size
......................................................................

Patch Set 11:

(1 comment)

File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/77338/comment/8c92ecea_3f49965d :
PS11, Line 630: 	root->max_payload_set = 1;
> I think this still doesn't catch case where two endpoints have different max payload sizes, for exam […]

So basically, at the end of root port scanning, we need to set the root port's Max Payload Size to all children, and children's children, etc. No need to restart the scan loop. Unfortunately I am not sure we have a configuration like that. Maybe if there is a PCIe WIFI card with Max Payload Size of 128B then yes.