[coreboot-gerrit] [S] Change in coreboot[master]: lib/fmap.c: Show error on fmd flash size mismatch with Kconfig

[Martin L Roth (Code Review)]

Attention is currently required from: Shelley Chen, Tarun Tuli, Subrata Banik, Julius Werner, Arthur Heymans.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69486 )

Change subject: lib/fmap.c: Show error on fmd flash size mismatch with Kconfig
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/69486/comment/97cd486f_d89cc0bb 
PS1, Line 14: in helping to eliminate the confusion.
> Not really sure what more there needs to be done, I think this should report the problem reliably?

I don't remember what I was thinking of when I wrote it.  Removed.

Patchset:

PS1:
> On Herobrine there's a weird situation where some of the early test boards were built by Qualcomm wi […]

Thanks for the explanation and example.

File src/lib/fmap.c:

https://review.coreboot.org/c/coreboot/+/69486/comment/4d87d773_a5a6377d 
PS1, Line 23: #ifdef FMAP_SECTION_FLASH_SIZE
> Why would this ever not be defined? We rely on FMAP_OFFSET being available below as well, and this c […]

Done

https://review.coreboot.org/c/coreboot/+/69486/comment/e84821fb_b3866a6d 
PS1, Line 25: rom
> nit: "ROM"

Done