[coreboot-gerrit] [XL] Change in coreboot[main]: mb/novacustom: add V5x0TU board (Meteor Lake)

[Krystian Hebel (Code Review)]

Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski.

Krystian Hebel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82673?usp=email )

Change subject: mb/novacustom: add V5x0TU board (Meteor Lake)
......................................................................

Patch Set 12:

(4 comments)

File src/mainboard/novacustom/mtl-h/Kconfig:

https://review.coreboot.org/c/coreboot/+/82673/comment/59e257b3_2dbd1bb4?usp... :
PS12, Line 69: 512
1024 for DDR5

File src/mainboard/novacustom/mtl-h/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/82673/comment/dbea66dc_21d422b0?usp... :
PS12, Line 61: 				register "device_count" = "3"
Why 3?

File src/mainboard/novacustom/mtl-h/ramstage.c:

https://review.coreboot.org/c/coreboot/+/82673/comment/3b4fe2b9_865532e7?usp... :
PS12, Line 3: #include <ec/dasharo/ec/commands.h>
            : #include <ec/acpi/ec.h>
            : #include <ec/dasharo/ec/acpi.h>
            : #include <fmap.h>
            : #include <lib.h>
            : #include <mainboard/gpio.h>
            : #include <security/vboot/vboot_common.h>
Not all of those are needed. It seems that only functions from `mainboard/gpio.h` and `ec/acpi.h` are used.

https://review.coreboot.org/c/coreboot/+/82673/comment/a9e0a074_6899c6d1?usp... :
PS12, Line 43: 	params->CnviRfResetPinMux = 0x194CE404; // GPP_F04
Can those magic numbers be expressed as some macros from e.g. `gpio_defs.h` instead?