Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski.

View Change

4 comments:

• File src/mainboard/novacustom/mtl-h/Kconfig:

  • Patch Set #12, Line 69: 512

    1024 for DDR5

• File src/mainboard/novacustom/mtl-h/devicetree.cb:

  • Patch Set #12, Line 61: register "device_count" = "3"

    Why 3?

• File src/mainboard/novacustom/mtl-h/ramstage.c:

  • Patch Set #12, Line 3:

    #include <ec/dasharo/ec/commands.h>
    #include <ec/acpi/ec.h>
    #include <ec/dasharo/ec/acpi.h>
    #include <fmap.h>
    #include <lib.h>
    #include <mainboard/gpio.h>
    #include <security/vboot/vboot_common.h>
    

    Not all of those are needed. It seems that only functions from `mainboard/gpio.h` and `ec/acpi.h` are used.

  • Patch Set #12, Line 43: params->CnviRfResetPinMux = 0x194CE404; // GPP_F04

    Can those magic numbers be expressed as some macros from e.g. `gpio_defs.h` instead?

To view, visit change 82673. To unsubscribe, or for help writing mail filters, visit settings.