[coreboot-gerrit] Change in coreboot[master]: drivers/amd/i2s_machine_dev: Make DMIC select gpio optional

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52393 )

Change subject: drivers/amd/i2s_machine_dev: Make DMIC select gpio optional
......................................................................

drivers/amd/i2s_machine_dev: Make DMIC select gpio optional

In upcoming platforms, hotword detection is always going to be done
using the mic in user-facing camera. Hence dmic select gpio is not
required by the I2S machine driver. Hence make DMIC select gpio
configuration as optional.

BUG=b:182960979
TEST=Build and boot to OS in Guybrush. Ensure that the machine driver
ACPI object is populated without DMIC select GPIO.

Change-Id: Iba00b07c3656c487e33bab184fefee7037745e2d
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
1 file changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/52393/1

diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
index b5be31d..4dfb94f 100644
--- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
+++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
@@ -31,11 +31,6 @@
    	return;
    }

-	if (dmic_select_gpio->pin_count == 0) {
-		printk(BIOS_ERR, "%s: ERROR: DMIC select GPIO required\n", dev_path(dev));
-		return;
-	}
-
    acpigen_write_scope(scope); /* Scope */
    acpigen_write_device(acpi_device_name(dev)); /* Device */
    acpigen_write_name_string("_HID", cfg->hid);
@@ -44,6 +39,9 @@

acpigen_write_STA(acpi_device_status(dev));

+	if (!dmic_select_gpio->pin_count)
+		goto skip_resources_dsd;
+
    /* Resources */
    acpigen_write_name("_CRS");
    acpigen_write_resourcetemplate_header();
@@ -66,6 +64,7 @@
    		 0); /* Active low = 0 (Kernel driver does not use active polarity). */
    acpi_dp_write(dsd);

+skip_resources_dsd:
    acpigen_pop_len(); /* Device */
    acpigen_pop_len(); /* Scope */