1 Mar
2019
1 Mar
'19
11:57 a.m.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31617 )
Change subject: superio/ite/it8613e: add support for ITE IT8613E ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31617/4/src/superio/ite/it8613e/superio.c File src/superio/ite/it8613e/superio.c:
https://review.coreboot.org/#/c/31617/4/src/superio/ite/it8613e/superio.c@74 PS4, Line 74: 0x0fff
is this mask correct? I don't have the datasheet, but this seems a bit unusual to me; guessing from […]
I've rechecked it, those are correct according to specification. Some of others ITE chips have identical simple I/O BARs, e.g. IT8783.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31617
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73c083b7019163c1203a5aabbef7d9d8f5ccb16a
Gerrit-Change-Number: 31617
Gerrit-PatchSet: 4
Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 11:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment