Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 7:
(3 comments)
Ready for merge
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 PS7, Line 180: and any other native display initialization code is not run
I guess it would be best to make MUST_REQUEST_DISPLAY the default […]
The other option would be to have MUST_REQUEST_DISPLAY depend on the other relevant options that select for OPROM, libgfxinit, VGA_ROM_RUN, etc. But not totally sure how this would work -- the spiderweb of display-related options is pretty confusing.
https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32262/6/src/security/vboot/misc.h@40 PS6, Line 40: uint32_t buffer_size;
I don't remember the exact rules in the standard, but for the compilers we use (GCC/clang) you can g […]
Ack
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c File src/security/vboot/vboot_handoff.c:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c@8... PS7, Line 84: VBSD_OPROM_LOADED
Ack
Yup, that's right. Currently we are slated to have two flags:
vb2_context: VB2_CONTEXT_DISPLAY_INIT vb2_shared_data: VB2_SD_FLAG_DISPLAY_AVAILABLE