10 Jun
2019
10 Jun
'19
7:35 p.m.
hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32057 )
Change subject: mediatek/mt8183: modify vsim2 calibration ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32057/3/src/soc/mediatek/mt8183/mt6358.c File src/soc/mediatek/mt8183/mt6358.c:
https://review.coreboot.org/#/c/32057/3/src/soc/mediatek/mt8183/mt6358.c@782 PS3, Line 782: VSIM2_CALI_POS_60_MV
And line 781-784 looks equivalent to 'vsim2_cali = MAX(0, vsim2_cali - 6);' […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/32057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dffdde89cbde91286d92e6c2b445f0b3d0ad2fe
Gerrit-Change-Number: 32057
Gerrit-PatchSet: 4
Gerrit-Owner: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Jun 2019 02:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: You-Cheng Syu youcheng@google.com
Gerrit-MessageType: comment