Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/32533/9/src/southbridge/intel/common/Kconfig File src/southbridge/intel/common/Kconfig:
https://review.coreboot.org/#/c/32533/9/src/southbridge/intel/common/Kconfig... PS9, Line 70: depends on SOUTHBRIDGE_INTEL_COMMON
Why?
I only asked `why`, didn't mean to imply that it is wrong.
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... PS12, Line 55: ramstage-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_WATCHDOG) += watchdog.c
Done
We are talking a little past each other (or rather, I'm talking past you). What I meant was that your original `depends on SOUTHBRIDGE_INTEL_COMMON` was correct. And the explanation is that `pmbase.c` is only added to the build when it is selected.
NB. where you place `watchdog.c` in this file doesn't matter much. Dependencies should be modeled in Kconfig.