Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34941 )
Change subject: inteltool: add Lewisburg C62x chipset family PCI IDs ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34941/1//COMMIT_MSG@13 PS1, Line 13: datasheets/c620-series-chipset-datasheet.pdf Remove the link and just leave the document number as reference.
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 173: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C621 0xa1c1 Remove "LEWISBURG" to be consistent with the rest
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 179: #define PCI_DEVICE_ID_INTEL_LEWISBURG_C628 0xa1c7 C629 is missing.
https://review.coreboot.org/c/coreboot/+/34941/1/util/inteltool/inteltool.h@... PS1, Line 180: Please also add the Super SKU device IDs.