Nico Huber has posted comments on this change. ( https://review.coreboot.org/20913 )
Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds ......................................................................
Patch Set 4:
(1 comment)
Why don't you use existing interface to make coreboot compatible with tpacpi-bat and thinkpad_acpi?
I think a diff of patch set 3 and 4 answers the question: Left-hand side looks good, right-hand side looks like shit.
https://review.coreboot.org/#/c/20913/3/src/mainboard/lenovo/x200/acpi/bat_t... File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:
https://review.coreboot.org/#/c/20913/3/src/mainboard/lenovo/x200/acpi/bat_t... PS3, Line 38: * =0: Use battery default setting Why is there a space after `Store` but not after `Or`?