Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32791 )
Change subject: soc/intel/cannonlake: Configure SPI CS parameters in FSP UPD.
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32791/5/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32791/5/src/soc/intel/cannonlake/fsp_params....
PS5, Line 403: (
True, I just know that sometimes I forget the precedence and that keeps things clear. […]
I think parens improve readability in this case, and would favor keeping them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic816395b7d198a52c704e6cabcb56889150b741c
Gerrit-Change-Number: 32791
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 May 2019 15:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment