Angel Pons has uploaded this change for review. ( https://review.coreboot.org/28851
Change subject: util/autoport: Use romstage.c instead of early_southbridge.c ......................................................................
util/autoport: Use romstage.c instead of early_southbridge.c
Until now, autoport used to create a dummy "romstage.c", then write romstage code to "early_southbridge.c". While it works, it makes more sense to write to "romstage.c" instead, as virtually all mainboards do.
Change-Id: If9f9375f9a659e7e685de5f884163813261fa656 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/bd82x6x.go M util/autoport/main.go 2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/28851/1
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 31f7ced..887a520 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -299,9 +299,8 @@ File: "southbridge/intel/bd82x6x/acpi/pch.asl", })
- sb := Create(ctx, "early_southbridge.c") + sb := Create(ctx, "romstage.c") defer sb.Close() - AddROMStageFile("early_southbridge.c", "") Add_gpl(sb) sb.WriteString(`#include <stdint.h> #include <string.h> diff --git a/util/autoport/main.go b/util/autoport/main.go index 3071559..ed56a55 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -827,10 +827,6 @@ fmt.Fprintf(bi, "FIXME: put %s\n", missing) }
- rs := Create(ctx, "romstage.c") - defer rs.Close() - rs.WriteString("/* dummy file */\n") - if ROMSizeKB == 0 { KconfigBool["BOARD_ROMSIZE_KB_2048"] = true KconfigComment["BOARD_ROMSIZE_KB_2048"] = "FIXME: correct this"