[coreboot-gerrit] Change in ...coreboot[master]: WIP: Power resource stub

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32188 )

Change subject: WIP: Power resource stub
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > (21 comments)
> >
> > This CL should be broken down into multiple smaller CLs:
> > Adding probed property to sconfig to support probed devices
> > Adding power resource device to device tree
> > Adding power resource driver for ACPI
> > Adding helper function for enabling power in bootblock
> > Moving all mainboards using power resource to the newly added device
> > Get rid of power resource properties from I2C generic and SPI devices.
> > Get rid of probed property
>
> If power is enabled in bootblock, and probing is done in ramstage, when is the appropriate time to deassert reset?

I think typically it is the reset time which is longer? i.e. enable time is typically 1 or 2ms I believe? If that is correct, then I would expect reset to be de-asserted in bootblock too.