Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 422: This file mostly uses tabs after the command. It would be good to use that here and in the statements below as well.
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 426: dl Woops. Just remembered: shl only allows immediate or %cl. Sorry about the suggestion :(.
https://review.coreboot.org/c/coreboot/+/48286/5/src/soc/intel/common/block/... PS5, Line 435: /* : * Program MSR 0x1892 IA32_CR_SF_QOS_MASK_2 with : * total number of LLC ways : */ : movl $IA32_CR_SF_QOS_MASK_2, %ecx : xorl %edx, %edx : wrmsr Like mentioned on the earlier CL, I think IA32_CR_SF_QOS_MASK_2 is expected to be kept untouched.