Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35741 )
Change subject: mb/facebook/fbg1701: Add mainboard_read_pcb_version()
......................................................................
Patch Set 1: Code-Review+2
looks good to me; wouldn't it still be useful to print the CPLD version though?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c16627f468d84ca4ad2aab8bf9fb555f50dc23c
Gerrit-Change-Number: 35741
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 14:25:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment