Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35968 )
Change subject: mainboard/ocp/monolake: Hide IIO root ports before memory init
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35968/2/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/35968/2/src/mainboard/ocp/monolake/...
PS2, Line 29: include <soc/ubox.h>
Is this change related to the described patch? Or do you just clean it up here?
Seems like nothing else was changed here so why this include?
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/35968/2/src/soc/intel/fsp_broadwell...
PS2, Line 119: 0
You could use here %d and then provide BUS0 as parameter to be consistent. But this is just cosmetics
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a2a405f729df14f46bcf34a24e66e8ba9415f9d
Gerrit-Change-Number: 35968
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Oct 2019 06:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment