Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@12
PS1, Line 12: memeory
memory
Done
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@13
PS1, Line 13:
Was the memory part not booting before and now it's booting with this change?
the memory parts had been booting without this changes.
the change is for the part number string, we need the correct part number strings
in AV to apply the HW ID by the AVL part number.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4
Gerrit-Change-Number: 30909
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vincent Wang
vwang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Jan 2019 08:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment