David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add GPIO table to initialize custom configs ......................................................................
Patch Set 6:
(3 comments)
marking some more comments as resolved...
https://review.coreboot.org/c/coreboot/+/35367/3/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/35367/3/src/mainboard/ocp/monolake/... PS3, Line 64: {29, GPIO_MODE_GPIO, GPIO_OUTPUT, GPIO_OUT_LEVEL_HIGH, 0, 0}, /* H_BDXDE_PROCHOT_DISABLE */
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/35367/3/src/mainboard/ocp/monolake/... PS3, Line 68: {33, GPIO_MODE_GPIO, GPIO_OUTPUT, GPIO_OUT_LEVEL_HIGH, 0, 0}, /* PD_DMI_RX_TERMINATION */
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/35367/3/src/mainboard/ocp/monolake/... PS3, Line 81: {46, GPIO_MODE_GPIO, GPIO_OUTPUT, GPIO_OUT_LEVEL_HIGH, 0, 0}, /* FM_BIOS_POST_CMPLT_N */
line over 96 characters
Done