Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34653 )
Change subject: mb/google/octopus: Add custom SAR value for Vortininja
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34653/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/meep/variant.c:
https://review.coreboot.org/c/coreboot/+/34653/1/src/mainboard/google/octopu...
PS1, Line 33: return filename;
Why is this separate return statement needed? The next statement would be used.
I removed the return statement, and used break.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34653
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b3ab51e1d6cada4faaba1b9d72bd9eacf6b04dd
Gerrit-Change-Number: 34653
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 06:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment