Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: src: cast *cbmem_top_chipset() function to uintptr_t
......................................................................
Patch Set 18:
(2 comments)
We're not just casting in this change. If you are wanting to change the function definitions do so and note it. There are many casts in this change that aren't necessary.
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c
File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c@22
PS18, Line 22: static void *top;
Just change top's type.
https://review.coreboot.org/c/coreboot/+/43756/18/src/lib/imd_cbmem.c@29
PS18, Line 29: return (uintptr_t)_cbmem_top_ptr;
cast not needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12b105a5b49e2bbe2753a75eeff28fed29ee2297
Gerrit-Change-Number: 43756
Gerrit-PatchSet: 18
Gerrit-Owner: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: KOUAM Ledoux
kouamdoux@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 18:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment