Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31004 )
Change subject: mb/(ICH7): Remove initialization already done at early_init.c ......................................................................
mb/(ICH7): Remove initialization already done at early_init.c
V1CAP is a write-once register, and it is already programmed in intel/i945/early_init.c. Tested on 945G-M4 board (i945G + 82801GB).
Change-Id: I4469cb7505d584f10c98aec579a2d78bf1950bf3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31004 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/getac/p470/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c 7 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index 570360d..63042f6 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -143,8 +143,6 @@ { /* V0CTL Virtual Channel 0 Resource Control */ RCBA32(0x0014) = 0x80000001; - /* V1CAP Virtual Channel 1 Resource Capability */ - RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(0x3100) = 0x00042210; diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index b7b5efe..3bc4aa6 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -146,7 +146,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042220; diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index dbb2aa7..1257fa5 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -126,7 +126,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00042210; diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c index e085d12..18a7721 100644 --- a/src/mainboard/intel/d945gclf/romstage.c +++ b/src/mainboard/intel/d945gclf/romstage.c @@ -47,7 +47,6 @@ { /* Set up virtual channel 0 */ //RCBA32(0x0014) = 0x80000001; - //RCBA32(0x001c) = 0x03128010;
/* dev irq route register */ RCBA16(D31IR) = 0x0132; diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index efb03b1..565fe2f 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -76,7 +76,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 66ceffb..513e8e1 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -76,7 +76,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230; diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c index df15641..9d606f7 100644 --- a/src/mainboard/lenovo/z61t/romstage.c +++ b/src/mainboard/lenovo/z61t/romstage.c @@ -77,7 +77,6 @@ { /* Set up virtual channel 0 */ RCBA32(V0CTL) = 0x80000001; - RCBA32(V1CAP) = 0x03128010;
/* Device 1f interrupt pin register */ RCBA32(D31IP) = 0x00001230;