Attention is currently required from: Paul Menzel, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60216 )
Change subject: [TESTME] nb/intel/ironlake: Fix some quickpath init magic
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/60216/comment/741656aa_091c8f82
PS1, Line 3396: rdmsr(0x1ac); // !!!!
Hmmm, apparently this MSR is also read here for something else.
Left this rdmsr() call as-is for now because it's not related to this change. Reading this MSR has no side-effects.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60216
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd0139aa588dc8d948c03132b5c86866d90f3231
Gerrit-Change-Number: 60216
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 19 Dec 2021 12:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment