Marc Jones has submitted this change and it was merged. ( https://review.coreboot.org/19485 )
Change subject: amd/pi/hudson: Add config option for ACPI base ......................................................................
amd/pi/hudson: Add config option for ACPI base
Add a configuration option to assign the binaryPI base address for the ACPI registers. The binaryPI's assignment is determine at build time and no run-time configuration is allowed.
Change-Id: Ida17022abfa6faceb0653c2cb87aacce4facef09 Signed-off-by: Marc Jones marcj303@gmail.com Reviewed-on: https://review.coreboot.org/19485 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/southbridge/amd/pi/hudson/Kconfig M src/southbridge/amd/pi/hudson/hudson.h 2 files changed, 10 insertions(+), 1 deletion(-)
Approvals: Aaron Durbin: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig index 233260f..25dbdb8 100644 --- a/src/southbridge/amd/pi/hudson/Kconfig +++ b/src/southbridge/amd/pi/hudson/Kconfig @@ -219,6 +219,15 @@ help Set this option to y for serial IRQ in continuous mode. Otherwise it is in quiet mode. + +config HUDSON_ACPI_IO_BASE + hex + default 0x400 if CPU_AMD_PI_00670F00_FP4 || CPU_AMD_PI_00670F00_FT4 + default 0x800 + help + Base address for the ACPI registers. + This value must match the hardcoded value of AGESA. + endif
config HUDSON_UART diff --git a/src/southbridge/amd/pi/hudson/hudson.h b/src/southbridge/amd/pi/hudson/hudson.h index e20238f..2ccd485 100644 --- a/src/southbridge/amd/pi/hudson/hudson.h +++ b/src/southbridge/amd/pi/hudson/hudson.h @@ -51,7 +51,7 @@ #define PM_YANG_SD_FLASH_CTRL 0xE8 #define PM_PCIB_CFG 0xEA
-#define HUDSON_ACPI_IO_BASE 0x800 +#define HUDSON_ACPI_IO_BASE CONFIG_HUDSON_ACPI_IO_BASE #define ACPI_PM_EVT_BLK (HUDSON_ACPI_IO_BASE + 0x00) /* 4 bytes */ #define ACPI_PM1_CNT_BLK (HUDSON_ACPI_IO_BASE + 0x04) /* 2 bytes */ #define ACPI_PM_TMR_BLK (HUDSON_ACPI_IO_BASE + 0x18) /* 4 bytes */