Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Subrata Banik, EricR Lai.
Matt Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6:
Sorry, for the DSM format, this value is come from the SAR table itself, not form the CONFIG. […]
Hi Eric,
This CL is for EWRD, which is for 2nd, 3rd and 4th SAR table content writing into ACPI, nothing about DSM here.
PS6:
@Matt, I found the bug is from https://chromium-review.googlesource. […]
Hi Eric,
This is viable to fix that tool issue. I agree to fix that as well.
But I'd like to raise there are 2 ADL-P projects are done 6E SAR validation with this CL, if we request them to apply from tool fix and drop this CL in CB, they will be likely to walk through SAR validation again, which may cost more than they expect. This is for business purpose consideration.
PS6:
I wonder there is some bug when fill SAR table from the cbfs file.
Maybe, I am not clear since I was not involved for the developing codes process.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 02:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment