Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38134 )
Change subject: {mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device ......................................................................
{mb/facebook/fbg1701,mb/portwell/m107}: Drop PWRB device
The mainboard ASL code contained a power button definition. This is not required as the system uses the standard ACPI power button.
Remove the PWRB device from ASL.
BUG=N/A TEST=build
Found-by: fwts 19.12.00 Change-Id: I4fac1411fd99475551bc970818759649f80b3f0e Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38134 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/acpi/mainboard.asl D src/mainboard/portwell/m107/acpi/mainboard.asl M src/mainboard/portwell/m107/dsdt.asl 3 files changed, 0 insertions(+), 36 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl index af79bd7..a7c9849 100644 --- a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl +++ b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl @@ -16,15 +16,6 @@ * GNU General Public License for more details. */
-Scope (_SB) -{ - Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - Name (_UID, 1) - } -} - /* * Onboard CPLD */ diff --git a/src/mainboard/portwell/m107/acpi/mainboard.asl b/src/mainboard/portwell/m107/acpi/mainboard.asl deleted file mode 100644 index 2c325c6..0000000 --- a/src/mainboard/portwell/m107/acpi/mainboard.asl +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2012 Google Inc. - * Copyright (C) 2015 Intel Corp. - * Copyright (C) 2018 Eltan B.V. - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; version 2 of - * the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (_SB) -{ - Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - Name (_UID, 1) - } -} diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl index 6fcb39a..ced3e10 100644 --- a/src/mainboard/portwell/m107/dsdt.asl +++ b/src/mainboard/portwell/m107/dsdt.asl @@ -45,5 +45,4 @@
/* Mainboard specific sleep states */ #include "acpi/sleepstates.asl" - #include "acpi/mainboard.asl" }