[coreboot-gerrit] Change in coreboot[master]: device/oprom: Lists all supported vesa mode by oprom

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34284 )

Change subject: device/oprom: Lists all supported vesa mode by oprom
......................................................................

Patch Set 4: -Code-Review

(2 comments)

https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... 
File src/device/oprom/realmode/x86.c:

https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... 
PS4, Line 243: 	if (vbe_check_for_failure(X86_AH))
you could check for X86_AH == 3 here and handle it locally.

https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... 
PS4, Line 305: 		vbe_oprom_supported_mode_list();
> This may lead to unwanted recursion and the `default` case makes it even […]

good catch