[coreboot-gerrit] Change in coreboot[master]: binaryPI: implement C bootblock

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )

Change subject: binaryPI: implement C bootblock
......................................................................

Patch Set 18:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36914/18/src/drivers/amd/agesa/boot... 
File src/drivers/amd/agesa/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36914/18/src/drivers/amd/agesa/boot... 
PS18, Line 16: #include <cpu/x86/lapic.h>
             : #include <cpu/x86/mtrr.h>
             : #include <cpu/amd/msr.h>
why ?

https://review.coreboot.org/c/coreboot/+/36914/18/src/drivers/amd/agesa/boot... 
PS18, Line 26: timestamp_get
include <timestamp.h> ?

https://review.coreboot.org/c/coreboot/+/36914/18/src/drivers/amd/agesa/cach... 
File src/drivers/amd/agesa/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/36914/18/src/drivers/amd/agesa/cach... 
PS18, Line 40: 
related?