Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )
Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35035/8/src/arch/x86/early_dram.ld
File src/arch/x86/early_dram.ld:
https://review.coreboot.org/c/coreboot/+/35035/8/src/arch/x86/early_dram.ld@...
PS8, Line 37: *(.near_reset_vector);
Yes, I just repushed with an updated commit message ICYMI. I pasted the regions from readelf and you can see the >64K region with the .near_reset_vector tucked up near the very top of PROGBITS.
I'm not sure why KEEP() would've been required. FWIW I mocked it up on for C_ENVIRONMENT_BOOTBLOCK and built a google/grunt. I was able to build successfully once I provided a little more room between near_reset_vector and the reset vector. I can send that to you if you're interested. BTW, I didn't grow the bootblock; only inserted the new section name and verified it that reset/entry16/entry32 functionality moved.
Thanks for testing. Yes, it's be interested in seeing what I did wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c084ff6fdcf7e9154436f038705e8679daea780
Gerrit-Change-Number: 35035
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Oct 2019 05:35:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment